-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic column sizing to wsk activation list command #427
Conversation
@larandersson I see this error in Travis
|
@rabbah Did you observe the dependency to apache/openwhisk-client-go#120? It's not expected to work until that PR has been merged, and the build.gradle file has been updated to that commit. Not sure how you usually handle these kind of dependencies? |
Thanks. Just merged it. |
@rabbah Updated build.gradle. Now it should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the vendor file?
@rabbah Updated vendor.json as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased this to master to resolve conflicts.
This addresses apache/openwhisk-client-go#119 and adds dynamic sizing behavior to the Kind and Status columns, as well as skips the column heading if there are no activation records to display.
With this change, the behavior will be:
wsk activation list --skip 20 --limit 5
And, then for next pagination we can see how the columns change dynamically (see the Status and Entity columns):
wsk activation list --skip 25 --limit 5
This PR is dependent on apache/openwhisk-client-go#120, and when that has been merged into client-go, the
build.gradle
file needs to be updated to the commit hash of that PR.