Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alt. namespace resource uuid as tenant id to API gateway service #130

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Support alt. namespace resource uuid as tenant id to API gateway service #130

merged 6 commits into from
Oct 18, 2019

Conversation

mrutkows
Copy link
Contributor

No description provided.

@mrutkows mrutkows requested review from dubee and pritidesai October 17, 2019 17:59
@mrutkows mrutkows mentioned this pull request Oct 17, 2019
Merged
@mrutkows mrutkows requested review from mdeuser and removed request for dubee October 17, 2019 18:01
pritidesai
pritidesai approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mrutkows

steven0711dong
steven0711dong reviewed Oct 18, 2019
View reviewed changes
Copy link

@steven0711dong steven0711dong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on travis. Everything else looks good to me.

.travis.yml
go: "1.9.3"
services: docker
dist: xenial
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on travis but is the travis build failure related to these?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, it passed travis.

steven0711dong
steven0711dong approved these changes Oct 18, 2019
View reviewed changes
Copy link

@steven0711dong steven0711dong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.travis.yml
go: "1.9.3"
services: docker
dist: xenial
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, it passed travis.

@mrutkows mrutkows removed the request for review from mdeuser October 18, 2019 19:09
@mrutkows mrutkows marked this pull request as ready for review October 18, 2019 19:09
@mrutkows mrutkows merged commit ee5b870 into apache:master Oct 18, 2019
@mrutkows mrutkows deleted the iam-namespace branch February 10, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven0711dong steven0711dong steven0711dong approved these changes

@pritidesai pritidesai pritidesai approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrutkows @pritidesai @steven0711dong