Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error loging clearer #238

Merged
merged 2 commits into from
May 3, 2023
Merged

Make error loging clearer #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f6b82
Update error logs
Luke-Roy-IBM May 3, 2023
8b99ff3
fix typo
Luke-Roy-IBM May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/nodejsActionBase/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function initializeActionHandler(message) {
// The code is a base64-encoded zip file.
ext = detectFileType(message.code)
if (ext == 'unsupported'){
return Promise.reject("There was an error uncompressing the action archive.");
return Promise.reject("There was an error uncompressing the action archive. The file type is unsupported");
}
return extractInTmpDir(message.code)
.then(moduleDir => {
Expand Down Expand Up @@ -161,13 +161,13 @@ function extractInTmpDir(archiveFileContents) {
if (ext === 'zip') {
return exec("unzip -qq " + archiveFile + " -d " + tmpDir)
.then(res => path.resolve(tmpDir))
.catch(error => Promise.reject("There was an error uncompressing the action archive."));
.catch(error => Promise.reject("There was an error uncompressing the action Zip archive."));
} else if (ext === 'tar.gz') {
return exec("tar -xzf " + archiveFile + " -C " + tmpDir + " > /dev/null")
.then(res => path.resolve(tmpDir))
.catch(error => Promise.reject("There was an error uncompressing the action archive."));
.catch(error => Promise.reject("There was an error uncompressing the action Tar GZ archive."));
} else {
return Promise.reject("There was an error uncompressing the action archive.");
return Promise.reject("There was an error uncompressing the action archive. file ext did not Match");
}
});
});
Expand Down