Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/dev - updated intellij script to start controller and invoker locally #4142

Merged
merged 10 commits into from
Dec 6, 2018

Conversation

ddragosd
Copy link
Contributor

@ddragosd ddragosd commented Nov 29, 2018

Description

This PR updates gradlew :tools:dev:intellij to work with docker-compose and ansible locally . It basically makes the generation of IntelliJ configuration a bit more generic.

In addition, it adds a container factory for Mac, to expose action container ports on the host, as otherwise the invoker can't make HTTP requests to the action containers. Docker for Mac doesn't expose any direct route to containers.

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@ddragosd ddragosd added the review Review for this PR has been requested and yet needs to be done. label Nov 29, 2018
Copy link
Member

@chetanmeh chetanmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would simplify debugging some of the Invoker related flows in IDE. Some minor changes otherwise good to go

tools/dev/README.md Outdated Show resolved Hide resolved
@ddragosd ddragosd changed the title tools/dev - updated intellij script to accommodate docker-compose tools/dev - updated intellij script to start controller and invoker locally Dec 4, 2018
@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #4142 into master will increase coverage by 2.91%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4142      +/-   ##
==========================================
+ Coverage   77.91%   80.82%   +2.91%     
==========================================
  Files         151      152       +1     
  Lines        7277     7391     +114     
  Branches      468      473       +5     
==========================================
+ Hits         5670     5974     +304     
+ Misses       1607     1417     -190
Impacted Files Coverage Δ
.../containerpool/docker/DockerContainerFactory.scala 65.51% <ø> (+37.93%) ⬆️
...whisk/core/containerpool/docker/DockerClient.scala 97.95% <ø> (ø) ⬆️
...inerpool/docker/DockerForMacContainerFactory.scala 0% <0%> (ø)
...core/database/cosmosdb/RxObservableImplicits.scala 0% <0%> (-100%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0% <0%> (-95.54%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0% <0%> (-92.6%) ⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala 0% <0%> (-83.34%) ⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala 0% <0%> (-62.5%) ⬇️
...in/scala/org/apache/openwhisk/common/Counter.scala 40% <0%> (-20%) ⬇️
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala 92% <0%> (-4%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff21ec...d50b72c. Read the comment docs.

@ddragosd ddragosd merged commit 885f228 into apache:master Dec 6, 2018
@ddragosd ddragosd deleted the intellij-update branch December 11, 2018 16:10
BillZong pushed a commit to BillZong/openwhisk that referenced this pull request Nov 18, 2019
…ocally (apache#4142)

* tools/dev - updated intellij script for docker-compose
* Added support for docker for mac
* log-limit is 0 to avoid collection logs
* updates for wskdev with ansible
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Review for this PR has been requested and yet needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants