-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Scheduler] Implement FCPSchedulerServer #5030
Conversation
b2578f8
to
100d1ce
Compare
logger.warn(this, "Scheduler is disabled") | ||
scheduler.disable() | ||
complete("scheduler disabled") | ||
} ~ (path("queue" / "total") & get) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's put queue
in a constant as it will likely be reused as new api's are added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated accordingly, thanks for your review!
Codecov Report
@@ Coverage Diff @@
## master #5030 +/- ##
==========================================
- Coverage 82.10% 75.75% -6.35%
==========================================
Files 200 207 +7
Lines 9760 10034 +274
Branches 447 444 -3
==========================================
- Hits 8013 7601 -412
- Misses 1747 2433 +686
Continue to review full report at Codecov.
|
100d1ce
to
5dd6065
Compare
LGTM |
5dd6065
to
6c82d6e
Compare
6c82d6e
to
850ae67
Compare
Have any comment? |
I think @bdoyle0182 already approved this PR and it has been so long so we can merge this if it passes all CI tests. |
850ae67
to
0b292bf
Compare
0b292bf
to
a8a1f83
Compare
Description
This is the document for new Scheduler: https://cwiki.apache.org/confluence/display/OPENWHISK/New+architecture+proposal
Regarding FPCSchedulerServer, it provides some APIs to access the concrete info for scheduler node. including
When want to gracefully shutdown the scheduler, can invoke /disable
Related issue and scope
My changes affect the following components
Types of changes
Checklist: