Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-1717: Add geometry type #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ORC-1717: Add geometry type #18

wants to merge 2 commits into from

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented May 11, 2024

What changes were proposed in this pull request?

Add a new geometry type to Apache ORC.

Why are the changes needed?

Apache Iceberg is adding geospatial support: https://docs.google.com/document/d/1iVFbrRNEzZl8tDcZC81GFt01QJkLJsI9E2NBOt21IRI. It would be good if Apache ORC can support geometry type natively.

How was this patch tested?

N/A

@wgtmac wgtmac marked this pull request as ready for review May 12, 2024 08:15
@wgtmac wgtmac changed the title WIP: Add geometry type ORC-1717: Add geometry type May 12, 2024
@dongjoon-hyun
Copy link
Member

Thank you, @wgtmac . Is it for Apache ORC 1.1.0? If this is final, I'm +1.

@dongjoon-hyun
Copy link
Member

Also, cc @williamhyun

@wgtmac
Copy link
Member Author

wgtmac commented Jul 19, 2024

@dongjoon-hyun This is not finalized yet. I will update it once ready.

@dongjoon-hyun
Copy link
Member

Thank you! If it's finalized, please send a head-up email to dev@orc once more.

@dongjoon-hyun
Copy link
Member

Thank you for updating. Is this ready, @wgtmac ?

@wgtmac
Copy link
Member Author

wgtmac commented Aug 22, 2024

Yes, I believe so. And I will start PoC implementations later.

@dongjoon-hyun
Copy link
Member

Got it. When do you want to release orc-format v1.1?

  1. Now to help the PoC?
  2. After finishing PoC?

@wgtmac
Copy link
Member Author

wgtmac commented Aug 22, 2024

I think we can wait until both Java and C++ PoC implementations are finished.

@dongjoon-hyun
Copy link
Member

+1 for the decision. Thank you for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants