ORC-1487: Enable checkstyle on src/test with checkstyle-suppressions.xml
#1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mystic-lama , @williamhyun |
|
@dongjoon-hyun Awesome. I looked at adding this but was not sure if it was good idea. Thank you so much for this. Do we want to make Line length as change as part of this PR? |
|
Thank you, @mystic-lama . During reviewing your on-going PR, I evaluated our remaining work in the existing code and decided to ignore |
|
Thanks a ton @dongjoon-hyun |
|
Yes, we can handle them gradually in 2.1.0 or later. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 21, 2023
…ions.xml` ### What changes were proposed in this pull request? This PR aims to enable `checkstyle` on `src/test` directories to validate the recent PRs like #1590 . ### Why are the changes needed? To help the recent community work, we permanently declare the following rules as exception in test source code. ```xml <suppress checks="LineLength" files="src/test/*"/> <suppress checks="NewlineAtEndOfFile" files="src/test/*"/> <suppress checks="UnusedImports" files="src/test/*"/> <suppress checks="AvoidStarImport" files="src/test/*"/> <suppress checks="CustomImportOrder" files="src/test/*"/> ``` The other suppressed rules will be removed after we finish the test code clean-ups. ### How was this patch tested? Pass the CIs. Closes #1591 from dongjoon-hyun/ORC-1487. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d3d3b60) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
I backported this test infra PR to branch-1.9 and adjusted the JIRA issue versions. |
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
…ions.xml` ### What changes were proposed in this pull request? This PR aims to enable `checkstyle` on `src/test` directories to validate the recent PRs like apache#1590 . ### Why are the changes needed? To help the recent community work, we permanently declare the following rules as exception in test source code. ```xml <suppress checks="LineLength" files="src/test/*"/> <suppress checks="NewlineAtEndOfFile" files="src/test/*"/> <suppress checks="UnusedImports" files="src/test/*"/> <suppress checks="AvoidStarImport" files="src/test/*"/> <suppress checks="CustomImportOrder" files="src/test/*"/> ``` The other suppressed rules will be removed after we finish the test code clean-ups. ### How was this patch tested? Pass the CIs. Closes apache#1591 from dongjoon-hyun/ORC-1487. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to enable
checkstyleonsrc/testdirectories to validate the recent PRs like #1590 .Why are the changes needed?
To help the recent community work, we permanently declare the following rules as exception in test source code.
The other suppressed rules will be removed after we finish the test code clean-ups.
How was this patch tested?
Pass the CIs.