Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11673. List supported releases in Downloads page #102

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Nov 9, 2024

What changes were proposed in this pull request?

Update Downloads page to list only supported releases (currently 1.4.0). Older releases should not be promoted, but they are available from archives.

Also update other parts of the Downloads page, hopefully an improvement.

https://issues.apache.org/jira/browse/HDDS-11673

How was this patch tested?

hugo serve &
open http://localhost:1313/downloads/

👀

Screenshot for convenience:

Screenshot from 2024-11-12 07-50-02

Copy link
Contributor

@xichen01 xichen01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as an improvement to the downloads page. I'm not sure it clearly calls out that older releases are not being supported for security updates though. Do we want this information on this page so we don't have to update SECURITY.md in each release?

@adoroszlai
Copy link
Contributor Author

I'm not sure it clearly calls out that older releases are not being supported for security updates though.

I thought the header "Supported Releases" does that.

@adoroszlai
Copy link
Contributor Author

Updated:

Screenshot from 2024-11-13 08-17-54

@adoroszlai adoroszlai requested a review from errose28 November 13, 2024 15:21
Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @adoroszlai this looks much clearer now.

@errose28 errose28 merged commit 46c53e6 into apache:master Nov 13, 2024
1 check passed
@adoroszlai adoroszlai deleted the HDDS-11673 branch November 13, 2024 16:34
@adoroszlai
Copy link
Contributor Author

Thanks @errose28, @xichen01 for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants