HDDS-11344. Change dev server port to avoid conflict with Grafana. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
approved these changes
Aug 20, 2024
github-actions
bot
added
the
website-v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Port 3000 is the default for the Docusaurus dev server which comes from Node/React/Webpack, but it is also the default for Grafana. Ozone devs may have a Grafana instance running in docker already for testing which might conflict with the local preview, especially if they are updating Grafana related documentation. This PR changes the docusaurus default port to 3001 to avoid conflict.
What is the link to the Apache Jira?
HDDS-11344
How was this patch tested?
pnpm startruns on port 3001 by defaultdocker compose upruns on port 3001 by defaultpnpm build && pnpm serveruns on port 3001 by default