HDDS-9203. Allow generating/revoking S3 secret for other users via REST #5233
Conversation
|
|
||
| @POST | ||
| @Path("/{username}") | ||
| public Response generate(@PathParam("username") String username) |
There was a problem hiding this comment.
The current URL and HTTP action of each operation is
POST /secret/generate
POST /secret/generate/testuser2
POST /secret/revoke
POST /secret/revoke/testuser2
For a REST API, it usually leverages HTTP operations instead of put the operation/action name in the URL. I'd like to recommend change the URL and HTTP action to,
PUT /secret/
PUT /secret/testuser2
DELETE /secret/
DELETE /secret/testuser2
@ivanzlenko , the rest looks good.
There was a problem hiding this comment.
@ChenSammi thanks! I've changed this API.
There was a problem hiding this comment.
Also, does it make sense to add "Administration of S3 Secret" on this page https://ci-hadoop.apache.org/view/Hadoop%20Ozone/job/ozone-doc-master/lastSuccessfulBuild/artifact/hadoop-hdds/docs/public/security/securings3.html ? If that's the case then I create a follow ticket to do so.
There was a problem hiding this comment.
Yes, it's good to have a page for this new RESTful solution.
There is one Security section on this page https://ci-hadoop.apache.org/view/Hadoop%20Ozone/job/ozone-doc-master/lastSuccessfulBuild/artifact/hadoop-hdds/docs/public/interface/s3.html. about the CLI S3 Secret Management. It's better to co locate the new content with it. Maybe we can move the Security section content from s3.html to the Securing S3.html, then add a link in s3.html to refer to the new location.
There was a problem hiding this comment.
| import javax.ws.rs.core.Response; | ||
| import java.io.IOException; | ||
|
|
||
| import static javax.ws.rs.core.Response.Status.NOT_FOUND; | ||
|
|
||
| /** | ||
| * Revoke secret endpoint. | ||
| * Endpoint to generate and return S3 secret. |
There was a problem hiding this comment.
Endpoint to generate and return S3 secret. ->
Endpoint to manage S3 secret.
|
Thanks @ivanzlenko for the contribution. |
What changes were proposed in this pull request?
Add an ability to generate or revoke secret for custom user using S3 REST.
What is the link to the Apache JIRA
Please replace this section with the link to the Apache JIRA)](https://issues.apache.org/jira/browse/HDDS-9203)
How was this patch tested?
Patch is tested manually, via unit and smoke tests.