Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10007. Rename ManagedSstFileReader in rocksdb-checkpoint-differ #5859

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Dec 23, 2023

What changes were proposed in this pull request?

Rename ManagedSstFileReader in rocksdb-checkpoint-differ to avoid confusion with the "real" ManagedSstFileReader from hdds-managed-rocksdb.

/**
* Managed SstFileReader.
*/
public class ManagedSstFileReader extends ManagedObject<SstFileReader> {

/**
* ManagedSstFileReader provides an abstraction layer using which we can
* iterate over multiple underlying SST files transparently.
*/
public class ManagedSstFileReader {

I think SstFileSetReader would be a better name.

https://issues.apache.org/jira/browse/HDDS-10007

How was this patch tested?

CI:
https://github.com/adoroszlai/ozone/actions/runs/7309005071

@adoroszlai adoroszlai self-assigned this Dec 23, 2023
Copy link
Contributor

@swamirishi swamirishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @adoroszlai . Changes look good to me

@adoroszlai adoroszlai merged commit ddc19e9 into apache:master Dec 29, 2023
38 checks passed
@adoroszlai adoroszlai deleted the HDDS-10007 branch December 29, 2023 18:25
@adoroszlai
Copy link
Contributor Author

Thanks @swamirishi for the review.

xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 17, 2024
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 17, 2024
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants