Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-10192. Verify container checksum after downloaded #6078

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

DaveTeng0
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-10192 Verify container checksum after downloaded

Verify container checksum after downloaded to make sure the checksum matches the value stored in yaml;otherwise, throw error immediately.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10192

How was this patch tested?

unit test.

@DaveTeng0
Copy link
Contributor Author

Copy link
Contributor

@devmadhuu devmadhuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaveTeng0 for the patch. Just a minor comment.

@jojochuang
Copy link
Contributor

Looks like the newly added test failed. @DaveTeng0 could you check again?

@adoroszlai adoroszlai requested a review from jojochuang January 29, 2024 21:22
@jojochuang jojochuang merged commit af9a72a into apache:master Jan 30, 2024
35 checks passed
@jojochuang
Copy link
Contributor

Thanks @DaveTeng0 @adoroszlai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants