-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10552. Downgrade Surefire to 3.0.0-M4 #6406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai for the patch.
LGTM.
Thanks @hemantk-12 for the review. |
myskov
pushed a commit
to myskov/ozone
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit ca8f1f7)
myskov
pushed a commit
to myskov/ozone
that referenced
this pull request
Apr 3, 2024
(cherry picked from commit ca8f1f7)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 17, 2024
(cherry picked from commit ca8f1f7)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
(cherry picked from commit ca8f1f7)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 23, 2024
(cherry picked from commit ca8f1f7)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Oct 1, 2024
(cherry picked from commit ca8f1f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Workaround for SUREFIRE-1815, which affects 3.0.0-M5, by downgrading to M4. Cannot upgrade to M6 or newer, because forks are not killed correctly (SUREFIRE-1722, HDDS-10174) as of 3.2.5.
SUREFIRE-1815 causes intermittent fork timeout due to not being able to interrupt e.g. container scanner thread:
https://issues.apache.org/jira/browse/HDDS-10552
How was this patch tested?
Already verified that M4 correctly kills forks when needed (#6075).
Regular CI:
https://github.com/adoroszlai/ozone/actions/runs/8341980137
Flaky test check:
https://github.com/adoroszlai/ozone/actions/runs/8342506669 (unit)
https://github.com/adoroszlai/ozone/actions/runs/8342512159 (integration)