-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-9200. [Snapshot] Added logs and metrics for snapshot purge and set property APIs #6453
Conversation
...anager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @hemantk-12 Overall LGTM apart from one of the logging done.
...anager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hemantk-12 . lgtm
.../java/org/apache/hadoop/ozone/om/request/snapshot/TestOMSnapshotPurgeRequestAndResponse.java
Show resolved
Hide resolved
Thanks @smengcl and @swamirishi for the review. |
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
…et property APIs (apache#6453) (cherry picked from commit 3467db1)
… purge and set property APIs (apache#6453) Change-Id: Idbb2fb15100a46d0b117e84f7443d94cb58ace94
What changes were proposed in this pull request?
For snapshot purge and set snapshot property, there is no OM log or audit log. Without logs, it is hard to debug an issue like Snapshot chain corruption (e.g. HDDS-10524).
This change is to add logs so that, there is a way to know which snapshot is updated by which request. It also adds metrics for
SnapshotPurgeRequest
andSetSnapshotPropertyRequest
APIs for monitoring purposes.What is the link to the Apache JIRA
HDDS-9200
How was this patch tested?
Updated existing unit tests to validate that metrics are populated correctly.