HDDS-10682. EC Reconstruction creates empty chunks at the end of blocks with partial stripes #6515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs #6514 to get in first and then rebase. |
added 2 commits
April 12, 2024 09:44
…ks with partial stripes
adoroszlai
reviewed
Apr 12, 2024
| CompletableFuture<ContainerProtos.ContainerCommandResponseProto> | ||
| future = targetBlockStreams[i].write(bufs[i]); | ||
| checkFailures(targetBlockStreams[i], future); | ||
| if (bufs[i].limit() != 0) { |
There was a problem hiding this comment.
While this works OK, I think a better condition would be:
Suggested change
| if (bufs[i].limit() != 0) { | |
| if (bufs[i].remaining() > 0) { |
adoroszlai
approved these changes
Apr 12, 2024
|
Thanks @sodonnel for the fix. |
Tejaskriya
pushed a commit
to Tejaskriya/ozone
that referenced
this pull request
Apr 17, 2024
…ks with partial stripes (apache#6515)
sodonnel
added a commit
to sodonnel/hadoop-ozone
that referenced
this pull request
Apr 17, 2024
…ks with partial stripes (apache#6515) (cherry picked from commit a5fccbc)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 17, 2024
…ks with partial stripes (apache#6515) (cherry picked from commit a5fccbc)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
…ks with partial stripes (apache#6515) (cherry picked from commit a5fccbc)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Apr 18, 2024
…ks with partial stripes (apache#6515) (cherry picked from commit a5fccbc)
sodonnel
added a commit
to sodonnel/hadoop-ozone
that referenced
this pull request
Apr 18, 2024
…ks with partial stripes (apache#6515) (cherry picked from commit a5fccbc)
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
May 29, 2024
…ks with partial stripes (apache#6515) (cherry picked from commit a5fccbc)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
… end of blocks with partial stripes (apache#6515) (cherry picked from commit a5fccbc) Change-Id: I0c92e1e240c55d9ed0c7a9ae9a3bc6af4f43314d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Given an EC block that is larger than 1 full stripe, but the last stripe is partial so that it does not use all the index.
If one of the replicas is reconstructed that does not have any data in that final position, an empty chunk is written to the end of the block's chunk list.
While this does no cause any immediate problem, it can prevent further reconstructions that attempt to use this block, and they will fail with an error like:
If there are other spare replicas which can be used, reconstruction will continue, otherwise it will not be able to complete.
At this stage, I am not sure if this can affect reading a block via the normal read path.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10682
How was this patch tested?
Added a unit test to reproduce and then fixed the issue.