Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-10692. ozone s3 getsecret prints some internal details #6531

Merged
merged 1 commit into from
Apr 17, 2024
Merged

HDDS-10692. ozone s3 getsecret prints some internal details #6531

merged 1 commit into from
Apr 17, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

ozone s3 getsecret prints some additional items since HDDS-9444.

awsAccessKey=...
awsSecret=...
isDeleted=false
transactionLogIndex=0

The last two lines are internal details, should be omitted.

https://issues.apache.org/jira/browse/HDDS-10692

How was this patch tested?

Added assertion in robot test.

CI:
https://github.com/adoroszlai/ozone/actions/runs/8693821050

@adoroszlai adoroszlai self-assigned this Apr 15, 2024
ssulav
ssulav approved these changes Apr 15, 2024
View reviewed changes
Copy link

@ssulav ssulav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashishkumar50
ashishkumar50 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@ashishkumar50 ashishkumar50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adoroszlai Thanks for the patch, LGTM.

@adoroszlai adoroszlai merged commit 72240fa into apache:master Apr 17, 2024
39 checks passed
@adoroszlai adoroszlai deleted the HDDS-10692 branch April 17, 2024 04:10
@adoroszlai
Copy link
Contributor Author

Thanks @ashishkumar50, @ssulav for the review.

Tejaskriya pushed a commit to Tejaskriya/ozone that referenced this pull request Apr 17, 2024
@adoroszlai
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
771f5d3 
)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 17, 2024
@adoroszlai @xichen01
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
1352bfd 
)

(cherry picked from commit 72240fa)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 18, 2024
@adoroszlai @xichen01
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
3185336 
)

(cherry picked from commit 72240fa)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 18, 2024
@adoroszlai @xichen01
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
ede0aad 
)

(cherry picked from commit 72240fa)
@xichen01 xichen01 mentioned this pull request Apr 18, 2024
Merged
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 21, 2024
@adoroszlai @xichen01
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
1c181d2 
)

(cherry picked from commit 72240fa)
xichen01 pushed a commit to xichen01/ozone that referenced this pull request Apr 23, 2024
@adoroszlai @xichen01
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
966fe53 
)

(cherry picked from commit 72240fa)
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request May 29, 2024
@adoroszlai
HDDS-10692. ozone s3 getsecret prints some internal details (apache#6531
7f9f83a 
)

(cherry picked from commit 72240fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishkumar50 ashishkumar50 ashishkumar50 approved these changes

@ssulav ssulav ssulav approved these changes

Assignees

@adoroszlai adoroszlai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adoroszlai @ssulav @ashishkumar50