HDDS-10783. Close SstFileReaderIterator in RocksDBCheckpointDiffer

[hemantk-12]

What changes were proposed in this pull request?

SstFileReaderIterator is not getting closed in RocksDBCheckpointDiffer that could potentially leave the file descriptor open even after RocksDB compaction deletes the file. This change is to close the SstFileReaderIterator after the use.

What is the link to the Apache JIRA

HDDS-10783

How was this patch tested?

Existing tests.

[swamirishi]

Thanks for the patch @hemantk-12 LGTM

[hemantk-12]

Thanks @swamirishi for the quick review.

[errose28]

Is SstFileReader and the other RocksDB classes listed in this block supposed to be allowed imports for the checkpoint differ? It looks like direct use of this class instead of the managed version is what led to this bug.

[hemantk-12]

Is SstFileReader and the other RocksDB classes listed in this block supposed to be allowed imports for the checkpoint differ? It looks like direct use of this class instead of the managed version is what led to this bug.

@errose28 you are right, direct use of the RocksDB classes led to this bug. We should be able to remove most of the RocksDB's direct usage except RocksDB objects used in here.

Created follow up task: https://issues.apache.org/jira/browse/HDDS-10787

[adoroszlai]

supposed to be allowed imports for the checkpoint differ?

Filed HDDS-10008 some time ago to clean up the allowed imports (triggered by another leak, of Options, fixed in HDDS-10001).