-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10803. HttpServer fails to start with wildcard principal #6631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tanvipenumudy please review |
smengcl
approved these changes
May 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adoroszlai . Can confirm kerb-util
is in classpath files now:
$ sed 's/:/\n/g' ./share/ozone/classpath/ozone-datanode.classpath | grep kerb
$HDDS_LIB_JARS_DIR/kerb-core-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-pkix-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-asn1-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-util-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerb-util-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-config-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerb-crypto-1.0.1.jar
$ sed 's/:/\n/g' ./share/ozone/classpath/ozone-manager.classpath | grep kerb
$HDDS_LIB_JARS_DIR/kerb-core-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-pkix-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-asn1-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-util-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerb-util-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerby-config-1.0.1.jar
$HDDS_LIB_JARS_DIR/kerb-crypto-1.0.1.jar
etc.
Thanks @smengcl for the review. |
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
…ipal (apache#6631) (cherry picked from commit a15cc3e) Also bumps Kerby to 2.0.3 Change-Id: I06f43ad67fd080b1b318806ce80e4aa523cd9cef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix:
Hadoop's
KerberosUtil
requireskerb-util
to be on the classpath to useKeytab
. However, this code path is hit only in specific cases. One of these is when HTTP principal is set to wildcard (*
).Similarly,
kerb-core
may be required for usingPrincipalName
.https://issues.apache.org/jira/browse/HDDS-10803
How was this patch tested?
The patch changes Recon's HTTP principal in
ozonesecure
acceptance test environment to*
to have coverage for this case.Also verified
kerb-util
is on the classpath (logged inSTARTUP_MSG
).CI:
https://github.com/adoroszlai/ozone/actions/runs/8943525426/job/24569000209
https://github.com/adoroszlai/ozone/actions/runs/8943794693 (with dependency check fixed)