-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11503. Add Robot test to verify Container Balancer for EC containers. #7311
Changes from 6 commits
7e12cad
475f28b
efd7df1
ff64806
5975a48
91e84c9
f513011
9a80e03
a171ab8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,30 @@ | ||||||
#!/usr/bin/env bash | ||||||
# Licensed to the Apache Software Foundation (ASF) under one | ||||||
# or more contributor license agreements. See the NOTICE file | ||||||
# distributed with this work for additional information | ||||||
# regarding copyright ownership. The ASF licenses this file | ||||||
# to you under the Apache License, Version 2.0 (the | ||||||
# "License"); you may not use this file except in compliance | ||||||
# with the License. You may obtain a copy of the License at | ||||||
# | ||||||
# http://www.apache.org/licenses/LICENSE-2.0 | ||||||
# | ||||||
# Unless required by applicable law or agreed to in writing, software | ||||||
# distributed under the License is distributed on an "AS IS" BASIS, | ||||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
# See the License for the specific language governing permissions and | ||||||
# limitations under the License. | ||||||
|
||||||
#suite:balancer | ||||||
|
||||||
COMPOSE_DIR="$( cd "$( dirname "${BASH_SOURCE0}" )" >/dev/null 2>&1 && pwd )" | ||||||
export COMPOSE_DIR | ||||||
export OM_SERVICE_ID="om" | ||||||
export OM=om1 | ||||||
export SCM=scm1 | ||||||
export OZONE_REPLICATION_FACTOR=3 | ||||||
|
||||||
source "$COMPOSE_DIR/../testlib.sh" | ||||||
|
||||||
start_docker_env 6 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
this parameter is not needed as "--scale" is not used and you defined each datanote separately There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||||||
execute_robot_test ${OM} -v REPLICATION:rs-3-2-1024k -v TYPE:EC -v KEYS:7 -v LOWER_LIMIT:1.5 -v UPPER_LIMIT:2.5 balancer/testBalancer.robot | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here as well.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
*** Settings *** | ||
Documentation Smoketest ozone cluster startup | ||
Library OperatingSystem | ||
Library String | ||
Library Collections | ||
Resource ../commonlib.robot | ||
Resource ../ozone-lib/shell.robot | ||
|
@@ -35,7 +36,7 @@ Prepare For Tests | |
Execute dd if=/dev/urandom of=/tmp/100mb bs=1048576 count=100 | ||
Run Keyword if '${SECURITY_ENABLED}' == 'true' Kinit test user testuser testuser.keytab | ||
Execute ozone sh volume create /${VOLUME} | ||
Execute ozone sh bucket create /${VOLUME}/${BUCKET} | ||
Execute ozone sh bucket create --replication ${REPLICATION} --type ${TYPE} /${VOLUME}/${BUCKET} | ||
|
||
|
||
Datanode In Maintenance Mode | ||
|
@@ -67,7 +68,7 @@ Run Container Balancer | |
Wait Finish Of Balancing | ||
${result} = Execute ozone admin containerbalancer status | ||
Should Contain ${result} ContainerBalancer is Running. | ||
Wait Until Keyword Succeeds 3min 10sec ContainerBalancer is Not Running | ||
Wait Until Keyword Succeeds 10min 10sec ContainerBalancer is Not Running | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this timeout increase necessary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
||
Sleep 60000ms | ||
|
||
Verify Verbose Balancer Status | ||
|
@@ -111,7 +112,7 @@ Create Multiple Keys | |
${fileName} = Set Variable file-${INDEX}.txt | ||
${key} = Set Variable /${VOLUME}/${BUCKET}/${fileName} | ||
LOG ${fileName} | ||
Create Key ${key} ${file} | ||
Create Key ${key} ${file} --replication=${REPLICATION} --type=${TYPE} | ||
Key Should Match Local File ${key} ${file} | ||
END | ||
|
||
|
@@ -126,14 +127,14 @@ Get Uuid | |
|
||
Close All Containers | ||
FOR ${INDEX} IN RANGE 15 | ||
${container} = Execute ozone admin container list --state OPEN | jq -r 'select(.replicationConfig.replicationFactor == "THREE") | .containerID' | head -1 | ||
${container} = Execute ozone admin container list --state OPEN | jq -r 'select(.replicationConfig.data == 3) | .containerID' | head -1 | ||
EXIT FOR LOOP IF "${container}" == "${EMPTY}" | ||
${message} = Execute And Ignore Error ozone admin container close "${container}" | ||
Run Keyword If '${message}' != '${EMPTY}' Should Contain ${message} is in closing state | ||
${output} = Execute ozone admin container info "${container}" | ||
Should contain ${output} CLOS | ||
END | ||
Wait until keyword succeeds 3min 10sec All container is closed | ||
Wait until keyword succeeds 4min 10sec All container is closed | ||
|
||
All container is closed | ||
${output} = Execute ozone admin container list --state OPEN | ||
|
@@ -146,15 +147,15 @@ Get Datanode Ozone Used Bytes Info | |
[return] ${result} | ||
|
||
** Test Cases *** | ||
Verify Container Balancer for RATIS containers | ||
Verify Container Balancer for RATIS/EC containers | ||
Prepare For Tests | ||
|
||
Datanode In Maintenance Mode | ||
|
||
${uuid} = Get Uuid | ||
Datanode Usageinfo ${uuid} | ||
|
||
Create Multiple Keys 3 | ||
Create Multiple Keys ${KEYS} | ||
|
||
Close All Containers | ||
|
||
|
@@ -175,8 +176,8 @@ Verify Container Balancer for RATIS containers | |
|
||
${datanodeOzoneUsedBytesInfoAfterContainerBalancing} = Get Datanode Ozone Used Bytes Info ${uuid} | ||
Should Not Be Equal As Integers ${datanodeOzoneUsedBytesInfo} ${datanodeOzoneUsedBytesInfoAfterContainerBalancing} | ||
Should Be True ${datanodeOzoneUsedBytesInfoAfterContainerBalancing} < ${SIZE} * 3.5 | ||
Should Be True ${datanodeOzoneUsedBytesInfoAfterContainerBalancing} > ${SIZE} * 3 | ||
Should Be True ${datanodeOzoneUsedBytesInfoAfterContainerBalancing} < ${SIZE} * ${UPPER_LIMIT} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great to have a description of what UPPER_LIMIT and LOWER_LIMIT are. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
Should Be True ${datanodeOzoneUsedBytesInfoAfterContainerBalancing} > ${SIZE} * ${LOWER_LIMIT} | ||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a test suite name that clearly indicates the replication type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done