Fix range check #7556
Closed
Fix range check #7556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I1d0419dd198b54ee6817f5790fcf31e3e2a94548
hemantk-12
reviewed
Dec 11, 2024
| @@ -101,8 +101,11 @@ public static boolean doesSstFileContainKeyRange(String filepath, | |||
| ManagedSstFileReaderIterator iterator = ManagedSstFileReaderIterator.managed( | |||
| sstFileReader.newIterator(readOptions))) { | |||
| iterator.get().seek(prefix.getBytes(UTF_8)); | |||
| String seekResultKey = new String(iterator.get().key(), UTF_8); | |||
| return seekResultKey.startsWith(prefix); | |||
| if (iterator.get().isValid()) { | |||
There was a problem hiding this comment.
Let's check the prefix against the first and last keys using isKeyWithPrefixPresent e.g. firstKey <= prefix <= lastKey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I1d0419dd198b54ee6817f5790fcf31e3e2a94548
What changes were proposed in this pull request?
Provide a one-liner summary of the changes in the PR Title field above.
It should be in the form of
HDDS-1234. Short summary of the change.Please describe your PR in detail:
perspective not just for the reviewer.
the Jira's description if the jira is well defined.
issue investigation, github discussion, etc.
Examples of well-written pull requests:
What is the link to the Apache JIRA
Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull
request which starts with the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
(Please replace this section with the link to the Apache JIRA)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)