-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-11775. Add tool to create RocksDB checkpoint #7664
Conversation
…matically create a checkpoint
…matically create a checkpoint
Thanks for adding this @Tejaskriya. I wonder if it would be better to have checkpoint as its own command? This would provide a few potential benefits:
I'm thinking something like |
@errose28 That does sound like a better idea. I'll update this PR with the new approach soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tejaskriya for the patch. LGTM, some code reuse suggested.
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/Checkpoint.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/Checkpoint.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/Checkpoint.java
Show resolved
Hide resolved
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/Checkpoint.java
Outdated
Show resolved
Hide resolved
Thanks for the review @adoroszlai, I have made the changes |
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/ldb/Checkpoint.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tejaskriya for updating the patch.
What changes were proposed in this pull request?
Some ozone debug tools may require a consistent view into the RocksDB instance to function correctly and may give incorrect results if the DB is being used by a running OM. To fix this, we can have ozone debug operate on a RocksDB checkpoint if the Ozone process is running. This avoids users having to manually install RocksDB's ldb and make the checkpoint themselves. An optional flag --checkpoint in introduced, that instructs the command to create a checkpoint from the RocksDB instance provided and read that instead.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11775
How was this patch tested?
Added a robot test in ozone-debug-ldb.