This repository has been archived by the owner on May 10, 2024. It is now read-only.
PARQUET-752: Account for upstream Arrow API changes #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
approved these changes
Oct 17, 2016
| @@ -45,6 +45,8 @@ using parquet::schema::GroupNode; | |||
| namespace parquet { | |||
| namespace arrow { | |||
|
|
|||
| namespace BitUtil = ::arrow::BitUtil; | |||
There was a problem hiding this comment.
Didn't know this would work. Why not use using here?
There was a problem hiding this comment.
Using doesn't work with namespaces AFAICT
|
Updated the thirdparty SHA. Guess I may have to wait til morning for the OS X builds |
|
The externalproject changes in Arrow broke the build, looking into it |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As soon as ARROW-261/317 are merged, I'll update the thirdparty git SHA so we can get a green build