Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PARQUET-2471: Add geometry logical type #240

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

PARQUET-2471: Add geometry logical type #240

wants to merge 30 commits into from

Commits on Oct 13, 2024

  1. WIP: Add geometry logical type

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5c9e110 View commit details
    Browse the repository at this point in the history

  2. address various comments

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5ef28cd View commit details
    Browse the repository at this point in the history

  3. add file level geo stats

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ecd8cc2 View commit details
    Browse the repository at this point in the history

  4. address feedback: 

    - remove file-level geo stats
- add custom wkb-encoded geometry stats
- comment out controversial items
    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d81dacb View commit details
    Browse the repository at this point in the history

  5. change naming and remove controversial items

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    80f4051 View commit details
    Browse the repository at this point in the history

  6. address feedback

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    0db6d9f View commit details
    Browse the repository at this point in the history

  7. fix typo

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e817af4 View commit details
    Browse the repository at this point in the history

  8. use WKB type code

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f78f7bd View commit details
    Browse the repository at this point in the history

  9. Update covering and geometry type protocol based on comments (#2)

    @zhangfengcdt @wgtmac
    zhangfengcdt authored and wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1aaaca8 View commit details
    Browse the repository at this point in the history

  10. Add the new suggestion according to the meeting with Snowflake (#3)

    @jiayuasu @wgtmac
    jiayuasu authored and wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ee5b2df View commit details
    Browse the repository at this point in the history

  11. change metadata to string type and rewording WKB description

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    19cc081 View commit details
    Browse the repository at this point in the history

  12. add example for crs

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    16c5868 View commit details
    Browse the repository at this point in the history

  13. reword crs

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    56a65de View commit details
    Browse the repository at this point in the history

  14. clarify WKB

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f28b282 View commit details
    Browse the repository at this point in the history

  15. clarify coverings

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5127702 View commit details
    Browse the repository at this point in the history

  16. Update the suggestion for bbox stats (#4) 

    * Add the new suggestion according to the meeting with Snowflake

* Refine the description according to the suggestion
    @jiayuasu @wgtmac
    jiayuasu authored and wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    298ab64 View commit details
    Browse the repository at this point in the history

  17. Update src/main/thrift/parquet.thrift 

    Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
    @wgtmac @paleolimbot
    wgtmac and paleolimbot committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    41c6394 View commit details
    Browse the repository at this point in the history

  18. Update src/main/thrift/parquet.thrift 

    Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
    @wgtmac @paleolimbot
    wgtmac and paleolimbot committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d86abe4 View commit details
    Browse the repository at this point in the history

  19. Update src/main/thrift/parquet.thrift 

    Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
    @wgtmac @paleolimbot
    wgtmac and paleolimbot committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c7a4f4c View commit details
    Browse the repository at this point in the history

  20. Update src/main/thrift/parquet.thrift 

    Co-authored-by: Dewey Dunnington <dewey@dunnington.ca>
    @wgtmac @paleolimbot
    wgtmac and paleolimbot committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f20f685 View commit details
    Browse the repository at this point in the history

  21. address feedback about edges and wkb

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dbf9d54 View commit details
    Browse the repository at this point in the history

  22. add geoparquet column metadata back

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b4296aa View commit details
    Browse the repository at this point in the history

  23. Update the spec according to the new feedback (#5) 

    * Update the spec according to the new feedback

* Fix typo
    @jiayuasu @wgtmac
    jiayuasu authored and wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9bcea6e View commit details
    Browse the repository at this point in the history

  24. Update src/main/thrift/parquet.thrift 

    Co-authored-by: emkornfield <emkornfield@gmail.com>
    @wgtmac @emkornfield
    wgtmac and emkornfield committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    99f0403 View commit details
    Browse the repository at this point in the history

  25. Update src/main/thrift/parquet.thrift 

    Co-authored-by: emkornfield <emkornfield@gmail.com>
    @wgtmac @emkornfield
    wgtmac and emkornfield committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dbb78cf View commit details
    Browse the repository at this point in the history

  26. add description to LogicalTypes.md

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    25df0ff View commit details
    Browse the repository at this point in the history

  27. add explanation for Z & M values

    @wgtmac
    wgtmac committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d349727 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. move geo stats to ColumnMetaData

    @wgtmac
    wgtmac committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9ea6559 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Update src/main/thrift/parquet.thrift 

    Co-authored-by: Jia Yu <jiayu@wherobots.com>
    @wgtmac @jiayuasu
    wgtmac and jiayuasu authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    011de45 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @wgtmac
    wgtmac committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6425a3c View commit details
    Browse the repository at this point in the history