-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PARQUET-2472: Close in finally block in ParquetFileWriter#end #1350
PARQUET-2472: Close in finally block in ParquetFileWriter#end #1350
Conversation
Working on creating a JIRA for this, I'm new to contributing to Parquet, so please let me know if there's anything I'm missing or should do, thanks! |
It's currently possible that ParquetFileWriter#end fails when writing out the footer, and we don't clean up resources. This change addresses this by explicitly closing the output stream in the finally block.
e08862f
to
90af1cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @amogh-jahagirdar, thanks for the fix 👍
…#1350) It's currently possible that ParquetFileWriter#end fails when writing out the footer, and we don't clean up resources. This change addresses this by explicitly closing the output stream in the finally block.
@amogh-jahagirdar do you want to backport this to 1.14.1 as well? |
It's currently possible that ParquetFileWriter#end fails when writing out the footer, and we don't clean up resources. This change addresses this by explicitly closing the output stream in the finally block.
Make sure you have checked all steps below.
Jira
them in the PR title. For example, "PARQUET-1234: My Parquet PR"
the ASF 3rd Party License Policy.
Tests
Commits
from "How to write a good git commit message":
Style
mvn spotless:apply -Pvector-plugins
Documentation