-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding some bad parquet files #58
Conversation
Just wonder how these file is generated? 🤔 These files are little, which is good for our testing |
# Conflicts: # bad_data/README.md
@jp0317 I've check the bad-dict file, it throw here in C++ code:
So maybe arrow-rs can also check this? ( also cc @alamb ) |
@pitrou Would you mind check the naming of the 2 new bad file here? Besides, the bad-levels file is similiar to existing bad level file, but I think one more bad file is ok. Want to hear what do you think of this |
I agree we should add tests to parquet-rs to test these bad files. I'll see what i can do |
I made a PR to check these files with Rust: apache/arrow-rs#6262 |
looks like the col start and length are checked against negative here but isn't checked against the file length. Beside, it seems we'd better check |
I've an issue here: apache/arrow-rs#6255 , glad to learn some rust code lol |
Hi, these two bad files can help reproduce the two examples mentioned in apache/arrow-rs#6228.