Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PredicateComparisonRewriter #14166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yashmayya
Copy link
Collaborator

  • These tests were originally added for Rewrite BETWEEN to >= AND <= #14102, but that PR was closed since we decided to go with a different approach.
  • This PR ports over the test related changes since the tests for the existing predicate comparison rewrites are still useful to include.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (59551e4) to head (b4dd47c).
Report is 1140 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14166      +/-   ##
============================================
+ Coverage     61.75%   63.80%   +2.05%     
- Complexity      207     1532    +1325     
============================================
  Files          2436     2621     +185     
  Lines        133233   144077   +10844     
  Branches      20636    22041    +1405     
============================================
+ Hits          82274    91934    +9660     
- Misses        44911    45343     +432     
- Partials       6048     6800     +752     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.76% <100.00%> (+2.05%) ⬆️
java-21 63.70% <100.00%> (+2.07%) ⬆️
skip-bytebuffers-false 63.78% <100.00%> (+2.03%) ⬆️
skip-bytebuffers-true 63.67% <100.00%> (+35.95%) ⬆️
temurin 63.80% <100.00%> (+2.05%) ⬆️
unittests 63.80% <100.00%> (+2.05%) ⬆️
unittests1 55.50% <100.00%> (+8.61%) ⬆️
unittests2 34.32% <75.00%> (+6.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants