-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky tests #14345
base: master
Are you sure you want to change the base?
Fix flaky tests #14345
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14345 +/- ##
============================================
+ Coverage 61.75% 63.92% +2.16%
- Complexity 207 1570 +1363
============================================
Files 2436 2681 +245
Lines 133233 147096 +13863
Branches 20636 22568 +1932
============================================
+ Hits 82274 94024 +11750
- Misses 44911 46142 +1231
- Partials 6048 6930 +882
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Is this PR ready to be reviewed? Seems all tests are still disabled |
Yes, PR can be reviewed. I added the annotations to disable tests when running them in IntelliJ, which doesn't recognize following maven settings:
I added a number of fixes to src/tests in pinot-segment-local to fix pinot data buffer leaks. |
This PR fixes unstable tests in pinot-common and pinot-segment-local so they can be executed reliably in a single jvm (e.g. in IDE).
Also - it enables test fork reuse in maven configuration.