Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests #14345

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

bziobrowski
Copy link
Contributor

@bziobrowski bziobrowski commented Oct 31, 2024

This PR fixes unstable tests in pinot-common and pinot-segment-local so they can be executed reliably in a single jvm (e.g. in IDE).
Also - it enables test fork reuse in maven configuration.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 63.92%. Comparing base (59551e4) to head (3768ca5).
Report is 1403 commits behind head on master.

Files with missing lines Patch % Lines
...ache/pinot/segment/spi/memory/PinotDataBuffer.java 20.00% 8 Missing ⚠️
...ment/index/readers/text/NativeTextIndexReader.java 66.66% 0 Missing and 1 partial ⚠️
...nt/local/utils/nativefst/NativeFSTIndexReader.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14345      +/-   ##
============================================
+ Coverage     61.75%   63.92%   +2.16%     
- Complexity      207     1570    +1363     
============================================
  Files          2436     2681     +245     
  Lines        133233   147096   +13863     
  Branches      20636    22568    +1932     
============================================
+ Hits          82274    94024   +11750     
- Misses        44911    46142    +1231     
- Partials       6048     6930     +882     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.89% <37.50%> (+2.18%) ⬆️
java-21 63.81% <37.50%> (+2.18%) ⬆️
skip-bytebuffers-false 63.91% <37.50%> (+2.17%) ⬆️
skip-bytebuffers-true 63.77% <37.50%> (+36.05%) ⬆️
temurin 63.92% <37.50%> (+2.16%) ⬆️
unittests 63.91% <37.50%> (+2.16%) ⬆️
unittests1 55.65% <18.75%> (+8.76%) ⬆️
unittests2 34.53% <25.00%> (+6.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jackie-Jiang
Copy link
Contributor

Is this PR ready to be reviewed? Seems all tests are still disabled

@bziobrowski
Copy link
Contributor Author

Yes, PR can be reviewed. I added the annotations to disable tests when running them in IntelliJ, which doesn't recognize following maven settings:

<!--Disabling tests as Pinot currently uses Yammer and these tests fail for DropwizardMetricsFactory-->
          <excludes>
            <exclude>**/DropwizardBrokerPrometheusMetricsTest.java</exclude>
            <exclude>**/DropwizardServerPrometheusMetricsTest.java</exclude>
            <exclude>**/DropwizardMinionPrometheusMetricsTest.java</exclude>
            <exclude>**/DropwizardControllerPrometheusMetricsTest.java</exclude>
          </excludes>

I added a number of fixes to src/tests in pinot-segment-local to fix pinot data buffer leaks.
I marked a few places that do not release resources in close() method with "TODO:".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants