Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds Support of maxNumRowsPerTask in RealtimeToOfflineSegmentsTasksGe… #14578

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Harnoor7
Copy link
Contributor

@Harnoor7 Harnoor7 commented Dec 2, 2024

@Harnoor7 Harnoor7 changed the title Adds Support of maxNumRowsPerTask in RealtimeToOfflineSegmentsTasksGe… [WIP] Adds Support of maxNumRowsPerTask in RealtimeToOfflineSegmentsTasksGe… Dec 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 78.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.96%. Comparing base (59551e4) to head (3233c33).
Report is 1412 commits behind head on master.

Files with missing lines Patch % Lines
...gments/RealtimeToOfflineSegmentsTaskGenerator.java 78.00% 8 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14578      +/-   ##
============================================
+ Coverage     61.75%   63.96%   +2.21%     
- Complexity      207     1573    +1366     
============================================
  Files          2436     2683     +247     
  Lines        133233   147348   +14115     
  Branches      20636    22589    +1953     
============================================
+ Hits          82274    94255   +11981     
- Misses        44911    46142    +1231     
- Partials       6048     6951     +903     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.94% <78.00%> (+2.23%) ⬆️
java-21 63.85% <78.00%> (+2.23%) ⬆️
skip-bytebuffers-false 63.96% <78.00%> (+2.21%) ⬆️
skip-bytebuffers-true 63.82% <78.00%> (+36.09%) ⬆️
temurin 63.96% <78.00%> (+2.21%) ⬆️
unittests 63.96% <78.00%> (+2.21%) ⬆️
unittests1 55.56% <ø> (+8.67%) ⬆️
unittests2 34.61% <78.00%> (+6.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants