Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the untarred file will be put outside of the target output directory #2835

Merged
merged 1 commit into from
May 22, 2018

Conversation

jackjlli
Copy link
Member

This PR adds code to check whether the untarred file will be put outside of the target output dir.

@jackjlli jackjlli self-assigned this May 22, 2018
@jackjlli jackjlli requested a review from mcvsubbu May 22, 2018 00:29
@codecov-io
Copy link

Codecov Report

Merging #2835 into master will increase coverage by 0.11%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
+ Coverage   69.11%   69.22%   +0.11%     
==========================================
  Files         908      908              
  Lines       43414    43417       +3     
  Branches     5887     5888       +1     
==========================================
+ Hits        30006    30056      +50     
+ Misses      11404    11357      -47     
  Partials     2004     2004
Impacted Files Coverage Δ
...edin/pinot/common/utils/TarGzCompressionUtils.java 75.25% <50%> (-1.34%) ⬇️
...ore/query/scheduler/resources/ResourceManager.java 87.09% <0%> (-9.68%) ⬇️
...e/impl/dictionary/LongOnHeapMutableDictionary.java 88.88% <0%> (-6.67%) ⬇️
.../impl/dictionary/FloatOnHeapMutableDictionary.java 86.66% <0%> (-6.67%) ⬇️
...n/pinot/core/io/writer/impl/MmapMemoryManager.java 80% <0%> (-6.16%) ⬇️
...e/operator/dociditerators/SortedDocIdIterator.java 59.45% <0%> (-5.41%) ⬇️
...afkaHighLevelConsumerBasedRoutingTableBuilder.java 92.3% <0%> (-3.85%) ⬇️
.../pinot/core/query/scheduler/PriorityScheduler.java 78.08% <0%> (-2.74%) ⬇️
...mpl/dictionary/DoubleOffHeapMutableDictionary.java 78.18% <0%> (-1.82%) ⬇️
...lix/core/realtime/PinotRealtimeSegmentManager.java 73.54% <0%> (-1.06%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6efb1ba...48c3cf9. Read the comment docs.

@jackjlli jackjlli merged commit 07b0508 into master May 22, 2018
@jackjlli jackjlli deleted the PWN-15256 branch May 22, 2018 04:31
@kishoreg
Copy link
Member

do we have a test case to check for the happy path and the failure path?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants