Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Use Github Action to check Markdown links #139

Closed
kevinjqliu opened this issue Aug 11, 2024 · 3 comments · Fixed by #141
Closed

[FEATURE REQUEST] Use Github Action to check Markdown links #139

kevinjqliu opened this issue Aug 11, 2024 · 3 comments · Fixed by #141
Labels
enhancement New feature or request

Comments

@kevinjqliu
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Use github-action-markdown-link-check Github Action to check for dead links in Markdown files.

Similar to iceberg-python#324

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@kevinjqliu kevinjqliu added the enhancement New feature or request label Aug 11, 2024
@bbrewington
Copy link
Contributor

I'm working on this on a fork, and will PR in

Just read CONTRIBUTING.md, and emailing over my ICLA now

@kevinjqliu
Copy link
Contributor Author

I had a PR started, but feel free to work on this! Feel free to add me as a reviewer

Should cover both docs/ and regtests/client/python/docs
Screenshot 2024-08-11 at 10 45 34 AM

@bbrewington bbrewington mentioned this issue Aug 11, 2024
Merged
6 tasks
@kevinjqliu
Copy link
Contributor Author

As a follow up, enable this github action for all MD files and for all PRs
See comment: #141 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@kevinjqliu @bbrewington