Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github add to check md link #324

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

kevinjqliu
Copy link
Contributor

No description provided.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for raising this PR

@bitsondatadev How cool is this!?

@kevinjqliu
Copy link
Contributor Author

Here's the result from the GitHub Action run from my fork
https://github.com/kevinjqliu/iceberg-python/actions/runs/7707078539/job/21003669945

@Fokko Fokko marked this pull request as ready for review February 28, 2024 12:06
@Fokko
Copy link
Contributor

Fokko commented Feb 28, 2024

This is great @kevinjqliu 🥳

@Fokko
Copy link
Contributor

Fokko commented Feb 28, 2024

@kevinjqliu can you fix this locally, I'm unable to fix this through the UI :/

@kevinjqliu
Copy link
Contributor Author

kevinjqliu commented Feb 29, 2024

@Fokko ran make lint locally, should be good now

@Fokko Fokko merged commit a1c6a5a into apache:main Feb 29, 2024
6 checks passed
@Fokko
Copy link
Contributor

Fokko commented Feb 29, 2024

Thanks for working on this @kevinjqliu

@kevinjqliu kevinjqliu deleted the kevinjqliu/markdown-link-check branch February 29, 2024 15:38
himadripal pushed a commit to himadripal/iceberg-python that referenced this pull request Mar 1, 2024
* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
@kevinjqliu kevinjqliu mentioned this pull request Mar 2, 2024
@HonahX HonahX added this to the PyIceberg 0.6.1 milestone Mar 27, 2024
HonahX pushed a commit to HonahX/iceberg-python that referenced this pull request Mar 28, 2024
* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>
Fokko added a commit that referenced this pull request Mar 29, 2024
* Github Action to check links in documentation (#324)

* add github add to check md link

* Only run under `mkdocs/**`

* ws

* make lint

---------

Co-authored-by: Fokko Driesprong <fokko@apache.org>

* Fix dead links in docs (#493)
Backport to 0.6.1

---------

Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Co-authored-by: Fokko Driesprong <fokko@apache.org>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants