[fix] Fix acknowledge MessageId list does not work when ackGroupingTimeMs is 0 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meMs is 0 ### Motivation When `ackGroupingTimeMs` is 0, `AckGroupingTrackerDisabled` will be created to acknowledge messages immediately. However, since the `addAcknowledgeList` method is not implemented in #23, it doesn't work. ### Modifications Implement `AckGroupingTrackerDisabled::addAcknowledgeList`. Move the protocol version validation from `AckGroupingTrackerEnabled` to the base class `AckGroupingTracker` so that the `doImmediateAck` overload that accepts `std::set<MessageId>` can be reused. Add testing params to `testAckMsgList` and `testAckMsgListWithMultiConsumer` so that various `ackGroupingTimeMs` can be verified.
|
@RobertIndie Please also include this PR in 3.1.0 since the VOTE of candidate-2 is not present yet. |
shibd
approved these changes
Nov 29, 2022
RobertIndie
approved these changes
Nov 30, 2022
RobertIndie
reviewed
Nov 30, 2022
RobertIndie
pushed a commit
that referenced
this pull request
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
ackGroupingTimeMsis 0,AckGroupingTrackerDisabledwill be created to acknowledge messages immediately. However, since theaddAcknowledgeListmethod is not implemented in #23, it doesn't work.Modifications
Implement
AckGroupingTrackerDisabled::addAcknowledgeList. Move the protocol version validation fromAckGroupingTrackerEnabledto the base classAckGroupingTrackerso that thedoImmediateAckoverload that acceptsstd::set<MessageId>can be reused.Add testing params to
testAckMsgListandtestAckMsgListWithMultiConsumerso that variousackGroupingTimeMscan be verified.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)