[fix] Close broker producer created after producer close #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
approved these changes
Nov 30, 2022
|
Please rebase to master to avoid broken CI |
BewareMyPower
approved these changes
Dec 1, 2022
erobot
force-pushed
the
fix-close-producer
branch
from
75ef146
to
b0ae51d
Compare
|
Rebased |
shibd
approved these changes
Dec 1, 2022
merlimat
pushed a commit
that referenced
this pull request
Dec 2, 2022
### Motivation Close broker producer created after producer close to prevent producers from keeping alive in broker, and fix a race condition here. Race condition sequence: 1. prodcuer.start() is called 2. handleCreateProducer() is called, and runs to right before setCnx() 3. closeAsync() is called and returns directly after getCnx() returns nullptr, so no CloseProducer cmd is sent 4. handleCreateProducer() continues 5. Result: Producer is closed and no CloseProducer cmd is sent to broker ### Modifications * Close broker producer created after producer close * Use mutex to prevent race condition. handleCreateProducer() and closeAsync() should be low frequency operations and using mutex here should not affect performance.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close broker producer created after producer close to prevent producers from keeping alive in broker, and fix a race condition here.
Race condition sequence:
Modifications
Verifying this change
This change added tests and can be verified as follows:
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededbug fix only
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)