[fix] Consumer batch receive will cause data loss. #228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the batch receive method may cause data loss.
The root cause is, when
peekMsg
can't add tomessages
(The batch has satisfied the batch receive policy), it has actually been popped.pulsar-client-cpp/lib/ConsumerImpl.cc
Lines 652 to 657 in ba7f59d
Modifications
Verifying this change
testBatchReceive
test to cover this case:Send 100 messages first, batch receive 10 messages at a time, and assert that all messages can be received.
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)