Use absolute path to find credential files in unit tests #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#339 ### Motivation Currently the relative path is used in unit tests to specify the token file (`.test-token.txt`) and the credential directory (`./test-conf`). If we don't run the `pulsar-tests` binary in a subdirectory, it won't be able to read these files. ### Modifications Add the macro `-DTOKEN_PATH="..." -DTEST_CONF_DIR="..."` to specify absolute paths according to the `PROJECT_SOURCE_DIR`, which is defined by CMake as the absolute path of the project directory. ### Verifications ```bash cmake -B build cmake --build build -j8 # Run the test in project directory ./build/tests/pulsar-tests --gtest_filter='AuthPlugin*:*testRSAEncryption:*testEncryptionFailure:*DecryptionFailedMessages' # Run the test in a subdirectory cd build ./tests/pulsar-tests --gtest_filter='AuthPlugin*:*testRSAEncryption:*testEncryptionFailure:*DecryptionFailedMessages' ```
BewareMyPower
requested review from
merlimat,
codelipenghui,
RobertIndie,
Demogorgon314 and
shibd
RobertIndie
approved these changes
Nov 9, 2023
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Nov 16, 2023
Migrate the PRs from the pulsar-client-cpp repo: - apache/pulsar-client-cpp#297 - apache/pulsar-client-cpp#236 - apache/pulsar-client-cpp#340
BewareMyPower
added a commit
to apache/pulsar-client-python
that referenced
this pull request
Nov 16, 2023
Migrate the PRs from the pulsar-client-cpp repo: - apache/pulsar-client-cpp#297 - apache/pulsar-client-cpp#236 - apache/pulsar-client-cpp#340
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2023
Fixes #339 ### Motivation Currently the relative path is used in unit tests to specify the token file (`.test-token.txt`) and the credential directory (`./test-conf`). If we don't run the `pulsar-tests` binary in a subdirectory, it won't be able to read these files. ### Modifications Add the macro `-DTOKEN_PATH="..." -DTEST_CONF_DIR="..."` to specify absolute paths according to the `PROJECT_SOURCE_DIR`, which is defined by CMake as the absolute path of the project directory. ### Verifications ```bash cmake -B build cmake --build build -j8 # Run the test in project directory ./build/tests/pulsar-tests --gtest_filter='AuthPlugin*:*testRSAEncryption:*testEncryptionFailure:*DecryptionFailedMessages' # Run the test in a subdirectory cd build ./tests/pulsar-tests --gtest_filter='AuthPlugin*:*testRSAEncryption:*testEncryptionFailure:*DecryptionFailedMessages' ``` (cherry picked from commit 47fb809)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
Motivation
Currently the relative path is used in unit tests to specify the token file (
.test-token.txt) and the credential directory (./test-conf). If we don't run thepulsar-testsbinary in a subdirectory, it won't be able to read these files.Modifications
Add the macro
-DTOKEN_PATH="..." -DTEST_CONF_DIR="..."to specify absolute paths according to thePROJECT_SOURCE_DIR, which is defined by CMake as the absolute path of the project directory.Verifications