Add the Consumer::getConsumerName API #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation C++ client supports setting the consumer name via `ConsumerConfiguration::setConsumerName` but it does not support getting the consumer name for a given consumer. ### Modifications Add the `getConsumerName` method to `ConsumerImplBase` to get the consumer name from the config and a public method with the same name to `Consumer`. Add `ConsumerTest.testConsumerName` to verify the consumer name is set correctly in the subscribe command.
BewareMyPower
requested review from
merlimat,
RobertIndie,
Demogorgon314 and
shibd
merlimat
approved these changes
Dec 4, 2023
RobertIndie
approved these changes
Dec 4, 2023
shibd
approved these changes
Dec 4, 2023
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Mar 22, 2024
BewareMyPower
added a commit
to apache/pulsar-client-python
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
C++ client supports setting the consumer name via
ConsumerConfiguration::setConsumerNamebut it does not support getting the consumer name for a given consumer.Modifications
Add the
getConsumerNamemethod toConsumerImplBaseto get the consumer name from the config and a public method with the same name toConsumer.Add
ConsumerTest.testConsumerNameto verify the consumer name is set correctly in the subscribe command.