Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance transaction functionality #1281

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

reugn
Copy link
Contributor

@reugn reugn commented Sep 6, 2024

Motivation

Various fixes and refactoring for transaction.

Modifications

  • Employ context in the Commit and Abort methods
  • Use client operation timeout
  • Use atomic.Int32 for the state
  • Make all state reads atomic
  • Clean up and improve error messages

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)

Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Good work!

@RobertIndie
Copy link
Member

Can you help resolve the conflict? @reugn

@RobertIndie RobertIndie added this to the v0.15.0 milestone Dec 16, 2024
# Conflicts:
#	pulsar/transaction_impl.go
@reugn
Copy link
Contributor Author

reugn commented Dec 16, 2024

@RobertIndie, resolved.

@crossoverJie
Copy link
Member

@reugn Please check the CI results

@reugn
Copy link
Contributor Author

reugn commented Dec 17, 2024

@crossoverJie, please approve the CI workflows.

@RobertIndie RobertIndie merged commit c9245bc into apache:master Dec 17, 2024
7 checks passed
@reugn reugn deleted the enhance-transaction-functionality branch December 17, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants