Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Add detailed message when connection failed #1320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RobertIndie
Copy link
Member

Fixes #1315

Motivation

Currently the go client will only throw an error without any detailed information when connection failed:

connection error

Modifications

  • Add detailed message when connection failed

Verifying this change

With this PR, the error message would be like:

failed to connect to broker: dial tcp [::1]:1234: connect: connection refused

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@RobertIndie RobertIndie added this to the v0.15.0 milestone Dec 16, 2024
@RobertIndie RobertIndie self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant