Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] Add Athenz authentication provider #227

Merged
merged 2 commits into from
Apr 25, 2020

Conversation

equanz
Copy link
Contributor

@equanz equanz commented Apr 17, 2020

Motivation

Support Athenz authentication at pulsar-client-go.

Modifications

Add Athenz provider into pulsar/internal/auth, and fix to run Provider.Init() in newClient() function.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Added unit test for Athenz Authentication Provider

(It seems that the project should add integration test into client_impl.go. However, integrating with Athenz isn't simple...)

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@nkurihar
Copy link

LGTM

@equanz
Copy link
Contributor Author

equanz commented Apr 21, 2020

run integration tests

@nkurihar nkurihar requested review from wolfstudy and merlimat April 22, 2020 02:50
@equanz
Copy link
Contributor Author

equanz commented Apr 22, 2020

@wolfstudy @merlimat
Could you review this please?

In this PR, fixed parseParams(), and Provider.Init() to run.

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hrsakai
Copy link
Contributor

hrsakai commented Apr 23, 2020

run integration tests

@wolfstudy wolfstudy merged commit 0f822ef into apache:master Apr 25, 2020
@wolfstudy wolfstudy added this to the 0.1.1 milestone Jun 9, 2020
@equanz equanz deleted the add_athenz_auth branch July 15, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants