[ISSUE-328] gets last message when LatestMessageID and inclusive #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quintans
changed the title
added 4 commits
July 23, 2020 17:23
Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
…usive Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
quintans
force-pushed
the
last-message-inclusive
branch
from
d64fffc to
5ee5bb2
Compare
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 15, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make `HasNext()` return true in case of `StartMessageIdInclusive` and `LastestMessageID` * make `TestReaderLatestInclusiveHasNext` test case be more robust
1 task
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `HasNext()` return true in case of `StartMessageIdInclusive` and `LastestMessageID` * make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust
wolfstudy
pushed a commit
that referenced
this pull request
Feb 19, 2021
* Fix reader with start latest message id inclusive (#329) Fixes #356 Fixes #419 Motivtions The changes made by the original PR #329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust * Renew the expired certs in integration-tests with script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paulo Pereira paulo.quintans@gmail.com
Fixes #328
Motivation
I have a service that when it restarts, it needs to know what was the last message successfully sent to pulsar.
A reader seems the logical place, since we can specify
StartMessageIDasLatestMessageID()andStartMessageIDInclusiveModifications
When the reader is created, verify if it startMessageIDInclusive true and startMessageID == lastestMessageID() and then get the last message id and seek to that message id.
Verifying this change
This change added tests and can be verified as follows:
StartMessageIDInclusiveandLastestMessageIDDoes this pull request potentially affect one of the following parts:
Documentation