Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade library and build plugin versions #140

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Upgrade library and build plugin versions #140

merged 10 commits into from
Dec 14, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Dec 12, 2023

Experiment:

  • Add version-catalog-update to manage version upgrades.
  • Upgrade Gradle
  • Attempt to run upgrades with version-catalog-update's versionCatalogUpdate task
  • Conform to new formatting requirements:
    • reformat code
    • rename *Test.java -> *Tests.java

onobc
onobc approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhotari this looks great! I did not know about this plugin - I will add the same in several other repos.

I think it will be helpful to add a few sentences in the README describing how to update etc..

gradle/libs.versions.toml Show resolved Hide resolved
@lhotari lhotari changed the title [EXPERIMENT] Upgrade library and build plugin versions Upgrade library and build plugin versions Dec 14, 2023
@lhotari lhotari marked this pull request as ready for review December 14, 2023 11:44
@lhotari lhotari requested a review from cbornet December 14, 2023 11:45
@lhotari lhotari merged commit 5317510 into apache:main Dec 14, 2023
1 check passed
@onobc onobc mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onobc onobc onobc approved these changes

@cbornet cbornet Awaiting requested review from cbornet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhotari @onobc