Add pulsar-client-reactive-bom module #194
Conversation
This commit introduces a BOM module to make consumption of the library more robust by avoid library version mismatches. Resolves apache#193
| @@ -50,6 +50,82 @@ With Maven: | |||
| </dependencies> | |||
| ---- | |||
|
|
|||
| [[pulsar-client-reactive-bom]] | |||
There was a problem hiding this comment.
Inspired by our works in Pulsar proper (here) but minimized a bit.
| @@ -19,8 +19,7 @@ | |||
|
|
|||
| plugins { | |||
| id 'java-library' | |||
| id 'maven-publish' | |||
| id 'signing' | |||
| id 'pulsar-client-reactive.publish-conventions' | |||
There was a problem hiding this comment.
Note
I pulled the publishing piece out into its own plugin as the BOM uses java-platform and the library modules use java-project and they do not play well. Now each user of the publish conventions specifies the from XYZ part of the publications block.
Messing w/ publishing things can be scary. To easy the fear, I did a ./gradlew pTML before and after this change and then did a folder compare and made sure the poms and module files were identical before and after. Only the local versions w/ the particular timestamp entry in the files were modified. I am comfortable and confident that this change is not a risk in this regard.
This commit introduces a BOM module to make consumption of the library more robust by avoid library version mismatches.
Resolves #193