[fix][sql] Remove useless configuration for Pulsar SQL (#20605)

apache · Jun 29, 2023 · 1211b14 · 1211b14
1 parent 37ae858
commit 1211b14
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 4 deletions.
diff --git a/pulsar-sql/presto-distribution/src/main/resources/conf/catalog/pulsar.properties b/pulsar-sql/presto-distribution/src/main/resources/conf/catalog/pulsar.properties
@@ -113,10 +113,6 @@ pulsar.bookkeeper-explicit-interval=0
 # running in same sql worker. 0 is represents disable the cache, default is 0.
 pulsar.managed-ledger-cache-size-MB = 0
 
-# Number of threads to be used for managed ledger tasks dispatching,
-# default is Runtime.getRuntime().availableProcessors().
-# pulsar.managed-ledger-num-worker-threads =
-
 # Number of threads to be used for managed ledger scheduled tasks,
 # default is Runtime.getRuntime().availableProcessors().
 # pulsar.managed-ledger-num-scheduler-threads =

diff --git a/...l/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/TestPulsarConnectorConfig.java b/...l/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/TestPulsarConnectorConfig.java
@@ -18,7 +18,13 @@
  */
 package org.apache.pulsar.sql.presto;
 
+import io.airlift.bootstrap.Bootstrap;
+import io.airlift.json.JsonModule;
+import io.trino.spi.type.TypeManager;
+import java.util.HashMap;
+import java.util.Map;
 import org.apache.pulsar.common.policies.data.OffloadPoliciesImpl;
+import org.mockito.Mockito;
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
@@ -100,4 +106,34 @@ public void testGetOffloadPolices() throws Exception {
         Assert.assertEquals(offloadPolicies.getS3ManagedLedgerOffloadServiceEndpoint(), endpoint);
     }
 
+    @Test
+    public void testAnnotatedConfigurations() {
+        Bootstrap app = new Bootstrap(
+                new JsonModule(),
+                new PulsarConnectorModule("connectorId", Mockito.mock(TypeManager.class)));
+
+        Map<String, String> config = new HashMap<>();
+
+        config.put("pulsar.managed-ledger-offload-driver", "aws-s3");
+        config.put("pulsar.offloaders-directory", "/pulsar/offloaders");
+        config.put("pulsar.managed-ledger-offload-max-threads", "2");
+        config.put("pulsar.offloader-properties", "{\"s3ManagedLedgerOffloadBucket\":\"offload-bucket\","
+                + "\"s3ManagedLedgerOffloadRegion\":\"us-west-2\","
+                + "\"s3ManagedLedgerOffloadServiceEndpoint\":\"http://s3.amazonaws.com\"}");
+        config.put("pulsar.auth-plugin", "org.apache.pulsar.client.impl.auth.AuthenticationToken");
+        config.put("pulsar.auth-params", "params");
+        config.put("pulsar.tls-allow-insecure-connection", "true");
+        config.put("pulsar.tls-hostname-verification-enable", "true");
+        config.put("pulsar.tls-trust-cert-file-path", "/path");
+        config.put("pulsar.bookkeeper-num-io-threads", "10");
+        config.put("pulsar.bookkeeper-num-worker-threads", "10");
+        config.put("pulsar.managed-ledger-num-scheduler-threads", "10");
+        config.put("pulsar.stats-provider", "org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider");
+        config.put("pulsar.stats-provider-configs", "{\"httpServerEnabled\":\"false\","
+                + "\"prometheusStatsHttpPort\":\"9092\","
+                + "\"prometheusStatsHttpEnable\":\"true\"}");
+
+        app.doNotInitializeLogging().setRequiredConfigurationProperties(config).initialize();
+    }
+
 }