[Broker] Fix replicated subscriptions related LightProto issues #10247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While investigating the issue about geo replication, #10054 , I came across some issues with handling of some deserialized replicated subscriptions related messages. LightProto reuses thread local instances and therefore a copy must be made before sharing with other threads.
Modifications
ReplicatedSubscriptionsSnapshot
before adding it toReplicatedSubscriptionSnapshotCache
MarkersMessageIdData
before adding it toresponses
map inReplicatedSubscriptionsSnapshotBuilder