Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade BookKeeper to 4.14.1 #10686

Merged
merged 4 commits into from
Jun 1, 2021
Merged

Upgrade BookKeeper to 4.14.1 #10686

merged 4 commits into from
Jun 1, 2021

Conversation

hangc0276
Copy link
Contributor

Motivation

Pulsar 2.8.0 should dependent on BookKeeper 4.14.0, otherwise will cause direct memory copy to heap. Discuss in #10330

This bug is fixed by apache/bookkeeper#2701

Modification

  1. upgrade BookKeeper to 4.14.0
  2. fix prometheus metric incompatible with bookkeeper 4.14.0, causing by interface changed by Allow to attach labels to metrics bookkeeper#2650

@hangc0276 hangc0276 self-assigned this May 24, 2021
@hangc0276 hangc0276 added area/metrics area/dependency Pull requests that update a dependency file labels May 24, 2021
@hangc0276 hangc0276 added this to the 2.8.0 milestone May 24, 2021
@hangc0276
Copy link
Contributor Author

BookKeeper 4.14.0 has prometheus metric bug, which will cause BookKeeper prometheus metric can't be accepted by Prometheus. Please don't merge this PR before it addressed.

@hangc0276 hangc0276 changed the title upgrade BookKeeper to 4.14.0 【Don't Merge】upgrade BookKeeper to 4.14.0 May 24, 2021
@eolivelli
Copy link
Contributor

BookKeeper 4.14.0 has prometheus metric bug, which will cause BookKeeper prometheus metric can't be accepted by Prometheus. Please don't merge this PR before it addressed.

Which bug?
Can you please link here the bug in BK issue tracker?

@hangc0276
Copy link
Contributor Author

BookKeeper 4.14.0 has prometheus metric bug, which will cause BookKeeper prometheus metric can't be accepted by Prometheus. Please don't merge this PR before it addressed.

Which bug?
Can you please link here the bug in BK issue tracker?

The BK bug is apache/bookkeeper#2718
Please help take a look before Pulsar 2.8.0 release. @sijie @jiazhai @merlimat @codelipenghui @eolivelli

@merlimat
Copy link
Contributor

@hangc0276 The release 4.14.1 is already available on Maven central. You can update this PR.

@hangc0276 hangc0276 changed the title 【Don't Merge】upgrade BookKeeper to 4.14.0 Upgrade BookKeeper to 4.14.1 Jun 1, 2021
@hangc0276
Copy link
Contributor Author

@merlimat @eolivelli @codelipenghui I have upgrade bookkeeper dependency to 4.14.1, PTAL, thanks.

eolivelli
eolivelli approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit e6b35d9 into apache:master Jun 1, 2021
yangl pushed a commit to yangl/pulsar that referenced this pull request Jun 23, 2021
@hangc0276 @yangl
Upgrade BookKeeper to 4.14.1 (apache#10686)
7c67ac4 
* upgrade BookKeeper to 4.14.0

* format code

* upgrade bookkeeper to 4.14.1 to fix prometheus metric bug

* update license

Co-authored-by: chenhang <chenhang@bigo.sg>
dlg99 pushed a commit to dlg99/pulsar that referenced this pull request Dec 1, 2021
@hangc0276 @dlg99
Upgrade BookKeeper to 4.14.1 (apache#10686)
2fba056 
* upgrade BookKeeper to 4.14.0

* format code

* upgrade bookkeeper to 4.14.1 to fix prometheus metric bug

* update license

Co-authored-by: chenhang <chenhang@bigo.sg>
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
@hangc0276 @ciaocloud
Upgrade BookKeeper to 4.14.1 (apache#10686)
4f63076 
* upgrade BookKeeper to 4.14.0

* format code

* upgrade bookkeeper to 4.14.1 to fix prometheus metric bug

* update license

Co-authored-by: chenhang <chenhang@bigo.sg>
Jason918 pushed a commit to Jason918/pulsar that referenced this pull request Aug 4, 2022
@hangc0276 @Jason918
Upgrade BookKeeper to 4.14.1 (apache#10686)
9769bae 
* upgrade BookKeeper to 4.14.0

* format code

* upgrade bookkeeper to 4.14.1 to fix prometheus metric bug

* update license

Co-authored-by: chenhang <chenhang@bigo.sg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@lhotari lhotari Awaiting requested review from lhotari

@merlimat merlimat Awaiting requested review from merlimat

@315157973 315157973 Awaiting requested review from 315157973

@jiazhai jiazhai Awaiting requested review from jiazhai

@sijie sijie Awaiting requested review from sijie

Assignees

@hangc0276 hangc0276

Labels
area/dependency Pull requests that update a dependency file area/metrics
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hangc0276 @eolivelli @merlimat @codelipenghui