Fix schema-understand doc. #11615
Merged
Fix schema-understand doc. #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
codelipenghui,
gaoran10,
BewareMyPower and
Anonymitaet
codelipenghui
approved these changes
Aug 10, 2021
BewareMyPower
requested changes
Aug 10, 2021
There was a problem hiding this comment.
I think this part of docs is initially for protobuf native schema, see #9079. Is it proper to use Avro schema as the example here?
|
@BewareMyPower hi, I think this example is used to explain struct schema. Both avro and protobuf are good, what do you think? |
|
OK, I also just found the original doc PR is a little confused because it contains both the schema definition part and protobuf native schema part. |
BewareMyPower
approved these changes
Aug 10, 2021
|
Thanks for your contribution. Does this affect only master or other versioned docs? |
Anonymitaet
added
the
doc
eolivelli
approved these changes
Aug 10, 2021
k2la
approved these changes
Aug 10, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
* Fix schema-understand doc. * Add some version change Co-authored-by: congbo <congbobo184@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now complex type example are not right, so fix it.