Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] add create functions with package URL related docs #11810

Merged

Conversation

freeznet
Copy link
Contributor

Fixes #11665

Motivation

#11666 add the implementation of package URL support, this PR works on the docs.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

For contributor

For this PR, do we need to update docs?

  • If yes, please update docs or create a follow-up issue if you need help.

  • If no, please explain why.

For committer

For this PR, do we need to update docs?

  • If yes,

    • if you update docs in this PR, label this PR with the doc label.

    • if you plan to update docs later, label this PR with the doc-required label.

    • if you need help on updating docs, create a follow-up issue with the doc-required label.

  • If no, label this PR with the no-need-doc label and explain why.

@freeznet freeznet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 27, 2021
@freeznet freeznet added this to the 2.9.0 milestone Aug 27, 2021
@freeznet freeznet self-assigned this Aug 27, 2021
@freeznet freeznet changed the title add package URL related docs [doc] add create functions with package URL related docs Aug 27, 2021
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Does this affect only master or other versioned docs?
If latter, could you please help update all affected versions? Thanks

site2/docs/functions-deploy.md Outdated Show resolved Hide resolved
@freeznet
Copy link
Contributor Author

@Anonymitaet thanks for the comments, I have pushed a new commit to address your comments, PTAL when you have time, thanks.

@Anonymitaet Anonymitaet merged commit 75158ce into apache:master Aug 30, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
* add package URL related docs

* address comments
momo-jun added a commit to momo-jun/pulsar that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. release/2.8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pulsar-admin functions cannot use package URL to create function
2 participants