[PIP 97][Authorization Service] Remove unused authenticate method #12951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
changed the title
merlimat
approved these changes
Nov 29, 2021
merlimat
added
the
type/cleanup
michaeljmarshall
deleted the
remove-authentication-service-authenticate
branch
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #12105
Motivation
This is the start of my work implementing PIP 97.
When I removed the Discovery Service in #12119, I removed the last usage of the
AuthenticationService#authenticatemethod. There is no need for this method, and instead of updating it to the async method (provider.authenticate(authData)was deprecated in PIP 97), it is better to remove it.Modifications
AuthenticationService#authenticateVerifying this change
This is a trivial change.
Does this pull request potentially affect one of the following parts:
This is not a breaking change.
Documentation
no-need-docNo docs need updating, as this is minor code cleanup.