[Issue 12958] Use payload size for isExceedMaximumMessageSize

[Jason918]

Fixes #12958

Motivation

See #12958

Modifications

Add Commands.getPayloadSize for get payload size from headerAndPayload ByteBuf.
Use this payload size for isExceedMaximumMessageSize

Verifying this change

• Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

• org.apache.pulsar.broker.admin.TopicPoliciesTest#testTopicMaxMessageSizeThreshHold

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

• Dependencies (does it add or upgrade a dependency): (no)
• The public API: (no)
• The schema: (no)
• The default values of configurations: (no)
• The wire protocol: (no)
• The rest endpoints: (no)
• The admin cli options: (no)
• Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

• no-need-doc
  Bug fix

[gaoran10]

It seems that you want to compute the real message payload size, but if the message is a batch message, even we skip the batch message metadata, the rest part will also include many single message metadata.

[Jason918]

It seems that you want to compute the real message payload size, but if the message is a batch message, even we skip the batch message metadata, the rest part will also include many single message metadata.

Yes, this fix is for non-batch messages.
For batching message, we still need to check the size at client side.

[Jason918]

This will be fixed by PIP-132 in #13591
Close this issue.