Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Avoid using blocking calls for the async method checkTopicOwnership #15023

Merged
merged 3 commits into from
Apr 6, 2022
Merged

[improve][broker] Avoid using blocking calls for the async method checkTopicOwnership #15023

merged 3 commits into from
Apr 6, 2022

Conversation

mattisonchao
Copy link
Member

Motivation

Avoid using blocking calls for the async method "checkTopicOwnership"

Modifications

  • Make checkOwnership to pure async.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc

@mattisonchao mattisonchao changed the title [improve][broker] Avoid using blocking calls for the async method "checkTopicOwnership" [improve][broker] Avoid using blocking calls for the async method checkTopicOwnership Apr 4, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 4, 2022
@merlimat merlimat added this to the 2.11.0 milestone Apr 4, 2022
@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Apr 4, 2022
Jason918
Jason918 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao
Copy link
Member Author

/pulsarbot rerun-failure-checks

@codelipenghui codelipenghui merged commit c59402e into apache:master Apr 6, 2022
@lhotari lhotari mentioned this pull request Apr 6, 2022
Closed
aparajita89 pushed a commit to aparajita89/pulsar that referenced this pull request Apr 18, 2022
@mattisonchao @aparajita-singh-flipkart
[improve][broker] Avoid using blocking calls for the async method ``c…
345c9b7 
…heckTopicOwnership`` (apache#15023)
codelipenghui pushed a commit that referenced this pull request Apr 19, 2022
@mattisonchao @codelipenghui
[improve][broker] Avoid using blocking calls for the async method ``c…
3d1b0b2 
…heckTopicOwnership`` (#15023)

(cherry picked from commit c59402e)
codelipenghui pushed a commit that referenced this pull request Apr 19, 2022
@mattisonchao @codelipenghui
[improve][broker] Avoid using blocking calls for the async method ``c…
9d0740b 
…heckTopicOwnership`` (#15023)

(cherry picked from commit c59402e)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Apr 19, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@mattisonchao
[improve][broker] Avoid using blocking calls for the async method ``c…
04185f7 
…heckTopicOwnership`` (apache#15023)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

@HQebupt HQebupt HQebupt approved these changes

@Jason918 Jason918 Jason918 approved these changes

@merlimat merlimat merlimat approved these changes

Assignees

@mattisonchao mattisonchao

Labels
cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.9.3 release/2.10.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mattisonchao @merlimat @Jason918 @HQebupt @Technoboy- @codelipenghui @Demogorgon314